| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1436590917.24939.62.camel@edumazet-glaptop2.roam.corp.google.com> Date: Sat, 11 Jul 2015 07:01:57 +0200 From: Eric Dumazet <eric.dumazet@...il.com> To: Florian Westphal <fw@...len.de> Cc: netdev@...r.kernel.org, Eric Dumazet <edumazet@...gle.com> Subject: Re: [PATCH -next] Revert "ipv4: use skb coalescing in defragmentation" On Sat, 2015-07-11 at 01:37 +0200, Florian Westphal wrote: > This reverts commit 3cc4949269e01f39443d0fcfffb5bc6b47878d45. > > There is nothing wrong with coalescing during defragmentation, it > reduces truesize overhead and simplifies things for the receiving > socket (no fraglist walk needed). > > However, it also destroys geometry of the original fragments. > While that doesn't cause any breakage (we make sure to not exceed largest > original size) ip_do_fragment contains a 'fastpath' that takes advantage > of a present frag list and results in fragments that (in most cases) > match what was received. > > In case its needed the coalescing could be done later, when we're sure > the skb is not forwarded. But discussion during NFWS resulted in > 'lets just remove this for now'. > > Cc: Eric Dumazet <edumazet@...gle.com> > Signed-off-by: Florian Westphal <fw@...len.de> > --- Acked-by: Eric Dumazet <edumazet@...gle.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists