lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 13 Jul 2015 17:04:40 +0800 From: Herbert Xu <herbert@...dor.apana.org.au> To: Konstantin Khlebnikov <khlebnikov@...dex-team.ru> Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com> Subject: Re: [PATCH] netlink: enable skb header refcounting before sending first broadcast On Mon, Jul 13, 2015 at 11:54:47AM +0300, Konstantin Khlebnikov wrote: > > I don't think that recv path should care about shared skb -- skb can be > delivered into only one socket anyway. The fact is that this is how the original code worked and was expected to do. The broadcast side would generate a shared skb and the recv side is supposed to only read it, not modify it. In fact apart from the skb->peeked bug netlink_recvmsg does all the right things and never modifies skb. Cheers, -- Email: Herbert Xu <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists