netdev - Re: [PATCH] ipv6: Fix finding best source address in ipv6_dev_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m2fv4s5bf4.wl@gmail.com>
Date:	Tue, 14 Jul 2015 00:23:27 +0900
From:	Hajime Tazaki <thehajime@...il.com>
To:	hideaki.yoshifuji@...aclelinux.com
Cc:	davem@...emloft.net, netdev@...r.kernel.org, ek@...gle.com
Subject: Re: [PATCH] ipv6: Fix finding best source address in ipv6_dev_get_saddr().

At Mon, 13 Jul 2015 23:28:10 +0900,
YOSHIFUJI Hideaki/吉藤英明 wrote:
> 
> Commit 9131f3de2 ("ipv6: Do not iterate over all interfaces when
> finding source address on specific interface.") did not properly
> update best source address available.  Plus, it introduced
> possible NULL pointer dereference.
> 
> Bug was reported by Erik Kline <ek@...gle.com>.
> Based on patch proposed by Hajime Tazaki <thehajime@...il.com>.
> 
> Fixes: 9131f3de24db4dc12199aede7d931e6703e97f3b ("ipv6: Do not
> 	iterate over all interfaces when finding source address
> 	on specific interface.")
> Signed-off-by: YOSHIFUJI Hideaki <hideaki.yoshifuji@...aclelinux.com>

all of my tests passed with the patch on 14fe22e: Revert
"ipv4: use skb coalescing in defragmentation".

thanks for the prompt fix !

Acked-by: Hajime Tazaki <thehajime@...il.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html