netdev - RE: [PATCH] net: qlcnic: Deletion of unnecessary memset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <262CB373A6D1F14F9B81E82F74F77D5A472C2759@avmb2.qlogic.org>
Date:	Tue, 14 Jul 2015 08:48:10 +0000
From:	Shahed Shaikh <shahed.shaikh@...gic.com>
To:	Christophe JAILLET <christophe.jaillet@...adoo.fr>,
	Dept-GE Linux NIC Dev <Dept-GELinuxNICDev@...gic.com>
CC:	netdev <netdev@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH] net: qlcnic: Deletion of unnecessary memset

> -----Original Message-----
> From: Christophe JAILLET [mailto:christophe.jaillet@...adoo.fr]
> Sent: Tuesday, July 14, 2015 1:22 AM
> To: Shahed Shaikh; Dept-GE Linux NIC Dev
> Cc: netdev; linux-kernel; kernel-janitors@...r.kernel.org; Christophe JAILLET
> Subject: [PATCH] net: qlcnic: Deletion of unnecessary memset
> 
> There is no need to memset memory allocated with vzalloc.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>  drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
> b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
> index 2f6cc42..7dbab3c 100644
> --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
> +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
> @@ -2403,7 +2403,6 @@ int qlcnic_alloc_tx_rings(struct qlcnic_adapter
> *adapter,
>  			qlcnic_free_tx_rings(adapter);
>  			return -ENOMEM;
>  		}
> -		memset(cmd_buf_arr, 0, TX_BUFF_RINGSIZE(tx_ring));
>  		tx_ring->cmd_buf_arr = cmd_buf_arr;
>  		spin_lock_init(&tx_ring->tx_clean_lock);
>  	}

Acked-by: Shahed Shaikh <shahed.shaikh@...gic.com>

Thanks,
Shahed
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html