netdev - Re: [PATCH net-next v5 1/4] net core: Add protodown support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACcJQnSnbCVXhLuVfSQF_T1NZS+yr8Ozzp_S+_1nOFWHN2gSoA@mail.gmail.com>
Date:	Mon, 13 Jul 2015 18:09:48 -0700
From:	Anuradha Karuppiah <anuradhak@...ulusnetworks.com>
To:	David Miller <davem@...emloft.net>
Cc:	Scott Feldman <sfeldma@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Roopa Prabhu <roopa@...ulusnetworks.com>,
	Andy Gospodarek <gospo@...ulusnetworks.com>,
	Wilson Kok <wkok@...ulusnetworks.com>
Subject: Re: [PATCH net-next v5 1/4] net core: Add protodown support.

On Mon, Jul 13, 2015 at 2:34 PM, David Miller <davem@...emloft.net> wrote:
> From: anuradhak@...ulusnetworks.com
> Date: Thu,  9 Jul 2015 15:35:27 -0700
>
>> +/* proto_flags - port state information can be passed to the switch driver and
>> + * used to determine the phys state of the switch port */
>> +enum {
>> +     IF_PROTOF_DOWN          = 1<<0  /* set switch port phys state down */
>> +};
>
> Realistically, do we really foresee any other proto flags being added in
> the future?
>
> Unless there is a strong sense that we will have some, this is
> insanely overengineered with all of these bit masking capabilities and
> such and nested attributes.
>
> I'd say just do one boolean attribute and that's it.
Ack, I will resubmit with protodown as a boolean. Thanks for the review Dave.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html