netdev - Re: [PATCH net] rtnetlink: reject non-IFLA_VF_PORT attributes inside IFLA_VF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 14 Jul 2015 07:49:24 -0700
From:	roopa <roopa@...ulusnetworks.com>
To:	Daniel Borkmann <daniel@...earbox.net>
CC:	davem@...emloft.net, netdev@...r.kernel.org,
	Scott Feldman <sfeldma@...il.com>,
	Jason Gunthorpe <jgunthorpe@...idianresearch.com>
Subject: Re: [PATCH net] rtnetlink: reject non-IFLA_VF_PORT attributes inside
 IFLA_VF_PORTS

On 7/12/15, 3:06 PM, Daniel Borkmann wrote:
> Similarly as in commit 4f7d2cdfdde7 ("rtnetlink: verify IFLA_VF_INFO
> attributes before passing them to driver"), we have a double nesting
> of netlink attributes, i.e. IFLA_VF_PORTS only contains IFLA_VF_PORT
> that is nested itself. While IFLA_VF_PORTS is a verified attribute
> from ifla_policy[], we only check if the IFLA_VF_PORTS container has
> IFLA_VF_PORT attributes and then pass the attribute's content itself
> via nla_parse_nested(). It would be more correct to reject inner types
> other than IFLA_VF_PORT instead of continuing parsing and also similarly
> as in commit 4f7d2cdfdde7, to check for a minimum of NLA_HDRLEN.
>
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
> Cc: Roopa Prabhu <roopa@...ulusnetworks.com>
> Cc: Scott Feldman <sfeldma@...il.com>
> Cc: Jason Gunthorpe <jgunthorpe@...idianresearch.com>
>
Acked-by: Roopa Prabhu <roopa@...ulusnetworks.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html