netdev - Re: [PATCH net-next 2/3] rhashtable: allow lookup function to have compare function agument

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALx6S35rcBJtLeUQEnD3yc3nY2HC_KW_3b+pb8RFHt=GTx1Zng@mail.gmail.com>
Date:	Tue, 14 Jul 2015 08:43:52 -0700
From:	Tom Herbert <tom@...bertland.com>
To:	Thomas Graf <tgraf@...g.ch>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	Kernel Team <kernel-team@...com>,
	Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [PATCH net-next 2/3] rhashtable: allow lookup function to have
 compare function agument

On Tue, Jul 14, 2015 at 2:44 AM, Thomas Graf <tgraf@...g.ch> wrote:
> On 07/13/15 at 05:39pm, Tom Herbert wrote:
>> Added rhashtable_lookup_fast_cmpfn which does a lookup in an rhash table
>> with the compare function being taken from an argument. This allows
>> different compare functions to be used on the same table.
>>
>> Signed-off-by: Tom Herbert <tom@...bertland.com>
>
> Does this preserve the inlining guarantee? I remember Herbert had
> to write this carefully in order to avoid indirect calls.

It looks like the compare functions are still being properly inlined.
This is gcc 4.4.7.

Thanks,
Tom
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html