[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150714162850.GA8478@unicorn.suse.cz>
Date: Tue, 14 Jul 2015 18:28:50 +0200
From: Michal Kubecek <mkubecek@...e.cz>
To: Pablo Neira Ayuso <pablo@...filter.org>
Cc: netfilter-devel@...r.kernel.org, coreteam@...filter.org,
linux-api@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, Patrick McHardy <kaber@...sh.net>,
Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH nf-next] netfilter: nf_ct_sctp: minimal multihoming
support
On Tue, Jul 14, 2015 at 05:38:47PM +0200, Pablo Neira Ayuso wrote:
> On Tue, Jul 14, 2015 at 02:23:11PM +0200, Michal Kubecek wrote:
> > @@ -658,6 +696,18 @@ static struct ctl_table sctp_sysctl_table[] = {
> > .mode = 0644,
> > .proc_handler = proc_dointvec_jiffies,
> > },
> > + {
> > + .procname = "nf_conntrack_sctp_timeout_heartbeat_sent",
> > + .maxlen = sizeof(unsigned int),
> > + .mode = 0644,
> > + .proc_handler = proc_dointvec_jiffies,
> > + },
> > + {
> > + .procname = "nf_conntrack_sctp_timeout_heartbeat_acked",
> > + .maxlen = sizeof(unsigned int),
> > + .mode = 0644,
> > + .proc_handler = proc_dointvec_jiffies,
> > + },
> > { }
> > };
> >
> > @@ -705,6 +755,18 @@ static struct ctl_table sctp_compat_sysctl_table[] = {
> > .mode = 0644,
> > .proc_handler = proc_dointvec_jiffies,
> > },
> > + {
> > + .procname = "ip_conntrack_sctp_timeout_heartbeat_sent",
> > + .maxlen = sizeof(unsigned int),
> > + .mode = 0644,
> > + .proc_handler = proc_dointvec_jiffies,
> > + },
> > + {
> > + .procname = "ip_conntrack_sctp_timeout_heartbeat_acked",
> > + .maxlen = sizeof(unsigned int),
> > + .mode = 0644,
> > + .proc_handler = proc_dointvec_jiffies,
> > + },
> > { }
>
> I don't see the nla_policy updates for the netlink cttimeout
> interface.
I didn't realize those were needed. It means adding two entries to
sctp_timeout_nla_policy and two values to enum ctattr_timeout_sctp?
Or something else is also needed?
Michal Kubecek
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists