netdev - Re: [PATCH net-next v6 3/4] rocker: Handle protodown notifications.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 14 Jul 2015 19:42:51 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	anuradhak@...ulusnetworks.com, davem@...emloft.net,
	sfeldma@...il.com
CC:	netdev@...r.kernel.org, roopa@...ulusnetworks.com,
	gospo@...ulusnetworks.com, wkok@...ulusnetworks.com
Subject: Re: [PATCH net-next v6 3/4] rocker: Handle protodown notifications.

Hello.

On 07/14/2015 06:32 PM, anuradhak@...ulusnetworks.com wrote:

> From: Anuradha Karuppiah <anuradhak@...ulusnetworks.com>

> protodown can be set by user space applications like MLAG on detecting
> errors on a switch port. This patch provides sample switch driver changes
> for handling protodown. Rocker PHYS disables the port in response to
> protodown.

> Signed-off-by: Anuradha Karuppiah <anuradhak@...ulusnetworks.com>
> Signed-off-by: Andy Gospodarek <gospo@...ulusnetworks.com>
> Signed-off-by: Roopa Prabhu <roopa@...ulusnetworks.com>
> Signed-off-by: Wilson Kok <wkok@...ulusnetworks.com>
> ---
>   drivers/net/ethernet/rocker/rocker.c |   19 ++++++++++++++++++-
>   1 file changed, 18 insertions(+), 1 deletion(-)

> diff --git a/drivers/net/ethernet/rocker/rocker.c b/drivers/net/ethernet/rocker/rocker.c
> index 2d8578cade..ec950d9 100644
> --- a/drivers/net/ethernet/rocker/rocker.c
> +++ b/drivers/net/ethernet/rocker/rocker.c
> @@ -3983,7 +3983,8 @@ static int rocker_port_open(struct net_device *dev)
>
>   	napi_enable(&rocker_port->napi_tx);
>   	napi_enable(&rocker_port->napi_rx);
> -	rocker_port_set_enable(rocker_port, true);
> +	if (!(dev->proto_down))

    Inner parens not needed.

> +		rocker_port_set_enable(rocker_port, true);
>   	netif_start_queue(dev);
>   	return 0;
>
> @@ -4167,6 +4168,21 @@ static int rocker_port_get_phys_port_name(struct net_device *dev,
>   	return err ? -EOPNOTSUPP : 0;
>   }
>
> +static int rocker_port_change_proto_down(struct net_device *dev,
> +					 bool proto_down)
> +{
> +	struct rocker_port *rocker_port = netdev_priv(dev);
> +
> +	if (rocker_port->dev->flags & IFF_UP) {
> +		if (proto_down)
> +			rocker_port_set_enable(rocker_port, false);
> +		else
> +			rocker_port_set_enable(rocker_port, true);

    Why not:

		rocker_port_set_enable(rocker_port, !proto_down);

[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html