netdev - Re: [PATCH -next 0/6] Per network namespace netfilter chains

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87vbdljifn.fsf@x220.int.ebiederm.org>
Date:	Wed, 15 Jul 2015 15:05:00 -0500
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Pablo Neira Ayuso <pablo@...filter.org>
Cc:	netdev@...r.kernel.org, netfilter-devel@...r.kernel.org,
	Stephen Hemminger <stephen@...workplumber.org>,
	Juanjo Ciarlante <jjciarla@...z.uncu.edu.ar>,
	Wensong Zhang <wensong@...ux-vs.org>,
	Simon Horman <horms@...ge.net.au>,
	Julian Anastasov <ja@....bg>,
	Patrick McHardy <kaber@...sh.net>,
	Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
	Jamal Hadi Salim <jhs@...atatu.com>,
	Steffen Klassert <steffen.klassert@...unet.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH -next 0/6] Per network namespace netfilter chains

Pablo Neira Ayuso <pablo@...filter.org> writes:

> On Fri, Jul 10, 2015 at 06:11:46PM -0500, Eric W. Biederman wrote:
>> 
>> By maintining a set of functions to register and unregister netfilter
>> hooks both globally and per network namespace I have managed to write a
>> compact patchset that maintain per network netfilter chains, and
>> registers the nftables netfilter hooks per network namespace.
>
> Nice, thank you.
>
> It would be great to convert this to the for_each_net_rcu variant once
> we're sure this is safe.

That seems reasonable.

>> There are lots of other possible and desirable cleanups but this one is
>> a core change needed to make the other changes independent small
>> changes.
>
> The state->net field will kill that dev_net(...) ? x : y; all over the
> code, that would be nice.

Yes it will.  I intend to do that after this patchset settles so I am
not dealing with more than one issue at a time.  Otherwise there
is too much work at once.


> Some comments on your patchset:
>
> * 1/6 netfilter: nf_queue: Don't recompute the hook_list head
>
> I already passed this to current nf as you insisted on getting this,
> and for the sake of correctness, so it's basically already in David's
> net tree.

I would have expected this patch to be somewhere.  I did not see
this change in net-next when I wrote the patchset (which seemed
like a good approximation of the latest thing available).  If I
overlooked and the patch has already made it to Dave then my apologies
for being redundant.

I still don't see this patch in your pending branch.

Am I missing something?

> * From 2 to 6, I have applied these series with small coding style
>   cleanups.
>
> - Add line break between variable declaration and body:
>
>  +      struct list_head *nf_hook_list = &nf_hooks[pf][hook];
> -+
>  +      if (nf_hook_list_active(nf_hook_list, pf, hook)) {
>
> and here:
>
>  int nft_register_basechain(struct nft_base_chain *basechain,
>                            unsigned int hook_nops)
>   {
>  +      struct net *net = read_pnet(&basechain->pnet);
> ++
>
> - Get rid of unnecessary parens:
>
> -+      if ((reg->pf == NFPROTO_NETDEV) && (reg->hooknum == NF_NETDEV_INGRESS))
> ++      if (reg->pf == NFPROTO_NETDEV && reg->hooknum == NF_NETDEV_INGRESS)

Fair enough.  For me those parens are necessary to trust the compiler is
doing the right thing.  I can never remember the C operator precedence
rules.

> - Get rid of unnecesary brackets:
>
> -+      for_each_net(net) {
> ++      for_each_net(net)
>  +              nf_unregister_net_hook(net, reg);
> -+      }
>
> and here:
>
> -+      list_for_each_entry_continue_reverse(elem, &nf_hook_list, list) {
> ++      list_for_each_entry_continue_reverse(elem, &nf_hook_list, list)
>  +              nf_unregister_net_hook(net, elem);
> -+      }
>
> I have pushed this to:
>
> http://git.kernel.org/cgit/linux/kernel/git/pablo/nf-next.git/log/?h=pending
>
> in case you want to have a closer look. Thank you.

Thank you.

Eric

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html