netdev - Re: [PATCH v2 net-next 3/3] rhashtable: Add scored lookups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150715001854.GA29934@gondor.apana.org.au>
Date:	Wed, 15 Jul 2015 08:18:54 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Tom Herbert <tom@...bertland.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, tgraf@...g.ch,
	kernel-team@...com
Subject: Re: [PATCH v2 net-next 3/3] rhashtable: Add scored lookups

On Tue, Jul 14, 2015 at 04:45:49PM -0700, Tom Herbert wrote:
>
> +		} else if (score == best_score) {
> +			matches++;
> +			if (reciprocal_scale(khash, matches) == 0)
> +				result = he;
> +			khash = next_pseudo_random32(khash);
> +		}

Note that during a rehash you can encounter the same object multiple
times, does this logic still work in that case?

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html