netdev - Re: [PATCH net-next v7 0/4] net: Introduce protodown flag.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE4R7bC2WPDfJiT7Av8YYUybvc0D1cakKBgDsL+mystM33guFw@mail.gmail.com>
Date:	Tue, 14 Jul 2015 22:08:35 -0700
From:	Scott Feldman <sfeldma@...il.com>
To:	Anuradha Karuppiah <anuradhak@...ulusnetworks.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Netdev <netdev@...r.kernel.org>,
	Roopa Prabhu <roopa@...ulusnetworks.com>,
	Andy Gospodarek <gospo@...ulusnetworks.com>,
	Wilson Kok <wkok@...ulusnetworks.com>
Subject: Re: [PATCH net-next v7 0/4] net: Introduce protodown flag.

On Tue, Jul 14, 2015 at 1:43 PM,  <anuradhak@...ulusnetworks.com> wrote:
> From: Anuradha Karuppiah <anuradhak@...ulusnetworks.com>
>
> User space daemons can detect errors in the network that need to be
> notified to the switch device drivers.
>
> Drivers can react to this error state by doing a phy-down on the
> switch-port which would result in a carrier-off locally and on the directly
> connected switch. Doing that would prevent loops and black-holes in the
> network.

Hi Anuradha,

Since this is a switch-thingy, can you move this to switchdev port
attribute rather than adding another ndo op?  I know you started this
patch set before switchdev port attrs, but I think it's worthwhile
moving it to switchdev since clearly the use-case is switch device
drivers.   Let me know if you need help converting over to switchdev
port attr.

Also, is the sysfs interface necessary?  The netlink/iproute2
interface seems sufficient.

-scott
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html