netdev - Re: [PATCH] net: dsa: mv88e6xxx: fix fid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150715142322.GA32367@roeck-us.net>
Date:	Wed, 15 Jul 2015 07:23:22 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	linux-kernel@...r.kernel.org, kernel@...oirfairelinux.com
Subject: Re: [PATCH] net: dsa: mv88e6xxx: fix fid_mask when leaving bridge

On Wed, Jul 15, 2015 at 10:07:07AM -0400, Vivien Didelot wrote:
> The mv88e6xxx_priv_state structure contains an fid_mask, where 1 means
> the FID is free to use, 0 means the FID is in use.
> 
> This patch fixes the bit clear in mv88e6xxx_leave_bridge() when
> assigning a new FID to a port.
> 
> Example scenario: I have 7 ports, port 5 is CPU, port 6 is unused (no
> PHY). After setting the ports 0, 1 and 2 in bridge br0, and ports 3 and
> 4 in bridge br1, I have the following fid_mask: 0b111110010110 (0xf96).
> 
> Indeed, br0 uses FID 0, and br1 uses FID 3.
> 
> After setting nomaster for port 0, I get the wrong fid_mask: 0b10 (0x2).
> 
> With this patch we correctly get 0b111110010100 (0xf94), meaning port 0
> uses FID 1, br0 uses FID 0, and br1 uses FID 3.
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@...oirfairelinux.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html