netdev - Re: [V2 6/7] hvsock: introduce Hyper-V VM Sockets feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150715.211916.1258342954251964451.davem@davemloft.net>
Date:	Wed, 15 Jul 2015 21:19:16 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	decui@...rosoft.com
Cc:	gregkh@...uxfoundation.org, stephen@...workplumber.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	driverdev-devel@...uxdriverproject.org, olaf@...fle.de,
	apw@...onical.com, jasowang@...hat.com, kys@...rosoft.com,
	pebolle@...cali.nl
Subject: Re: [V2 6/7] hvsock: introduce Hyper-V VM Sockets feature

From: Dexuan Cui <decui@...rosoft.com>
Date: Tue, 14 Jul 2015 03:00:48 -0700

> +	pr_debug("hvsock_sk_destruct: called\n");

Debug logging just to state that a function is called is not appropriate,
we have very sophisticated tracing facilities in the kernel that can do
that transparently, and more.

PLease remove this.

> +	if (hvsk->channel) {
> +		pr_debug("hvsock_sk_destruct: calling vmbus_close()\n");

Likewise, these kinds of debug logs are totally inappropriate.

> +static int hvsock_release(struct socket *sock)
> +{
> +	/* sock->sk is NULL, if accept() is interrupted by a signal */
> +	if (sock->sk) {
> +		__hvsock_release(sock->sk);
> +		sock->sk = NULL;
> +	}
> +
> +	sock->state = SS_FREE;
> +	pr_debug("hvsock_release called\n\n");

Likewise.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html