netdev - Re: 4.1 regression in resizable hashtable tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150717102636.GA21732@orbit.nwl.cc>
Date:	Fri, 17 Jul 2015 12:26:36 +0200
From:	Phil Sutter <phil@....cc>
To:	Thomas Graf <tgraf@...g.ch>
Cc:	Meelis Roos <mroos@...ux.ee>, sparclinux@...r.kernel.org,
	Linux Kernel list <linux-kernel@...r.kernel.org>,
	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Daniel Borkmann <daniel@...earbox.net>,
	Geert Uytterhoeven <geert@...ux-m68k.org>
Subject: Re: 4.1 regression in resizable hashtable tests

On Fri, Jul 17, 2015 at 10:04:56AM +0200, Thomas Graf wrote:
> On 07/02/15 at 10:09pm, Meelis Roos wrote:
> > [   33.425061] Running rhashtable test nelem=8, max_size=65536, shrinking=0
> > [   33.425154] Test 00:
> > [   33.534470]   Adding 50000 keys
> > [   34.743553] Info: encountered resize
> > [   34.743698] Info: encountered resize
> > [   34.743838] Info: encountered resize
> > [   34.744057] Info: encountered resize
> > [   34.744430] Info: encountered resize
> > [   34.745139] Info: encountered resize
> > [   34.746441] Info: encountered resize
> > [   34.749055] Info: encountered resize
> > [   34.754469] Info: encountered resize
> > [   34.764836] Info: encountered resize
> > [   34.785696] Info: encountered resize
> > [   34.827448] Info: encountered resize
> > [   34.896936]   Traversal complete: counted=49993, nelems=50000, entries=50000, table-jumps=12
> > [   34.897056] Test failed: Total count mismatch ^^^
> 
> I do see count mismatches as well due to the design of the walker
> which restarts and thus sees certain entries multiple times.
> 
> Do you have this commit as well?
> 
> Author: Phil Sutter <phil@....cc>
> Date:   Mon Jul 6 15:51:20 2015 +0200
> 
>     rhashtable: fix for resize events during table walk

Thomas, this should be resolved already. Meelis replied[1] to my patch,
stating it fixes that problem for him. Though he's still waiting for
your proposed patch to add a schedule() call so the kernel won't
complain on his slow UltraSparc. :)

Cheers, Phil

[1]: http://www.spinics.net/lists/netdev/msg335767.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html