netdev - Re: [PATCHv2 RFC net-next] net/vxlan: Fix kernel unaligned access in __vxlan_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150718044641.GD30336@oracle.com>
Date:	Sat, 18 Jul 2015 06:46:41 +0200
From:	Sowmini Varadhan <sowmini.varadhan@...cle.com>
To:	Joe Perches <joe@...ches.com>
Cc:	netdev@...r.kernel.org, alexander.duyck@...il.com,
	davem@...emloft.net
Subject: Re: [PATCHv2 RFC net-next] net/vxlan: Fix kernel unaligned access in
 __vxlan_find_mac

On (07/17/15 16:07), Joe Perches wrote:
> On Fri, 2015-07-17 at 22:00 +0200, Sowmini Varadhan wrote:
> > __vxlan_find_mac invokes ether_addr_equal on the eth_addr field,
> > which triggers unaligned access messages, so rearrange vxlan_fdb
> > to avoid this in the most non-intrusive way.
> 
> What arch does this?

sparc.

BTW, I was also getting a lot of alignment errors from 
vxlan_xmit_skb (vxh comes out unaligned) for the IPv6 path.
I did not have time to investigate/fix this correctly- not sure
if this is specific to v6.

--Sowmini

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html