netdev - Re: [PATCH net-next] net: #ifdefify sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150719.114228.179586744105997642.davem@davemloft.net>
Date:	Sun, 19 Jul 2015 11:42:28 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	minipli@...glemail.com
Cc:	pablo@...filter.org, kaber@...sh.net, kadlec@...ckhole.kfki.hu,
	netdev@...r.kernel.org, netfilter-devel@...r.kernel.org
Subject: Re: [PATCH net-next] net: #ifdefify sk_classid member of struct
 sock

From: Mathias Krause <minipli@...glemail.com>
Date: Sun, 19 Jul 2015 20:17:41 +0200

> The sk_classid member is only required when CONFIG_CGROUP_NET_CLASSID is
> enabled. #ifdefify it to reduce the size of struct sock on 32 bit
> systems, at least.
> 
> Signed-off-by: Mathias Krause <minipli@...glemail.com>

Are you sure NFT_META_CGROUP cannot enter nft_meta_get_eval()?  If so it'll
WARN_ON().

I really don't like changes like this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html