netdev - Re: [PATCH net] net: dsa: bcm_sf2: do not use indirect reads and writes for 7445E0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150720.164903.725476389726819459.davem@davemloft.net>
Date:	Mon, 20 Jul 2015 16:49:03 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	f.fainelli@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net] net: dsa: bcm_sf2: do not use indirect reads and
 writes for 7445E0

From: Florian Fainelli <f.fainelli@...il.com>
Date: Wed, 15 Jul 2015 16:09:32 -0700

> 7445E0 contains an ECO which disconnected the internal SF2 pseudo-PHY which was
> known to conflict with the external pseudo-PHY of BCM53125 switches. This
> motivated the need to utilize the internal SF2 MDIO controller via indirect
> register reads/writes to control external Broadcom switches due to this address
> conflict (both responded at address 30d).
> 
> For 7445E0, the internal pseudo-PHY of the SF2 switch got disconnected, and as
> a consequence this prevents the internal SF2 MDIO bus controller from reading
> data (reads back everything as 0) since the MDI line is tied low.
> 
> Fix this by making the indirect register reads and writes conditional to
> 7445D0, on 7445E0 we can utilize the SWITCH_MDIO controller (backed by
> mdio-unimac and not the DSA created slave MII bus).
> 
> We utilize of_machine_is_compatible() here since this is the only way for use
> to differentiate between these two chips in a way that does not violate layers
> or becomes (too) vendor-specific.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Applied, thanks Florian.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html