netdev - Re: [PATCH net-next 15/22] route: Extend flow representation with tunnel key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150720122729.GB17423@pox.localdomain>
Date:	Mon, 20 Jul 2015 14:27:29 +0200
From:	Thomas Graf <tgraf@...g.ch>
To:	Julian Anastasov <ja@....bg>
Cc:	roopa@...ulusnetworks.com, rshearma@...cade.com,
	ebiederm@...ssion.com, hannes@...essinduktion.org,
	pshelar@...ira.com, jesse@...ira.com, davem@...emloft.net,
	daniel@...earbox.net, tom@...bertland.com, edumazet@...gle.com,
	jiri@...nulli.us, marcelo.leitner@...il.com,
	stephen@...workplumber.org, jpettit@...ira.com, kaber@...sh.net,
	simon.horman@...ronome.com, joestringer@...ira.com,
	ast@...mgrid.com, weichunc@...mgrid.com, netdev@...r.kernel.org,
	dev@...nvswitch.org
Subject: Re: [PATCH net-next 15/22] route: Extend flow representation with
 tunnel key

On 07/17/15 at 11:25pm, Julian Anastasov wrote:
> 
> 	Hello,
> 
> On Fri, 17 Jul 2015, Thomas Graf wrote:
> 
> > Add a new flowi_tunnel structure which is a subset of ip_tunnel_key to
> > allow routes to match on tunnel metadata. For now, the tunnel id is
> > added to flowi_tunnel which allows for routes to be bound to specific
> > virtual tunnels.
> > 
> > Signed-off-by: Thomas Graf <tgraf@...g.ch>
> > ---
> 
> > +struct flowi_tunnel {
> > +	__be64			tun_id;
> > +};
> > +
> >  struct flowi_common {
> >  	int	flowic_oif;
> >  	int	flowic_iif;
> > @@ -30,6 +34,7 @@ struct flowi_common {
> >  #define FLOWI_FLAG_ANYSRC		0x01
> >  #define FLOWI_FLAG_KNOWN_NH		0x02
> >  	__u32	flowic_secid;
> > +	struct flowi_tunnel flowic_tun_key;
> 
> 	New input key for fib rules? It should be initialized
> at some places, we should not provide random values:

Good catch. I see several other fields uninitialized as well
but they only seemed used in the output path.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html