netdev - RE: [PATCH net-next] cxgb4: Add debugfs entry to enable/disable backdoor access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <26E3F92EC670BD429DB5CB319D773C13CD476E@nice.asicdesigners.com>
Date:	Mon, 20 Jul 2015 13:03:10 +0000
From:	Hariprasad S <hariprasad@...lsio.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	Casey Leedom <leedom@...lsio.com>,
	Nirranjan Kirubaharan <nirranjan@...lsio.com>
Subject: RE: [PATCH net-next] cxgb4: Add debugfs entry to enable/disable
 backdoor access


________________________________________
From: Sergei Shtylyov [sergei.shtylyov@...entembedded.com]
Sent: Monday, July 20, 2015 5:43 PM
To: Hariprasad S; netdev@...r.kernel.org
Cc: davem@...emloft.net; Casey Leedom; Nirranjan Kirubaharan
Subject: Re: [PATCH net-next] cxgb4: Add debugfs entry to enable/disable backdoor access

Hello.

On 7/20/2015 5:54 PM, Hariprasad Shenai wrote:

> Add debugfs entry 'use_backdoor' to enable/disable backdoor access
> to read sge context. By default, we read sge context's via firmware. In
> case of FW issues, one can enable backdoor access via debugfs to dump
> sge context for debugging purpose.

> Signed-off-by: Hariprasad Shenai <hariprasad@...lsio.com>
[...]
> diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c
> index b135d05..5b525a7 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c
> @@ -2386,8 +2386,11 @@ int t4_setup_debugfs(struct adapter *adap)
>                                       EXT_MEM_SIZE_G(size));
>       }
>
> -     de = debugfs_create_file_size("flash", S_IRUSR, adap->debugfs_root, adap,
> -                                   &flash_debugfs_fops, adap->params.sf_size);
> +     de = debugfs_create_file_size("flash", S_IRUSR, adap->debugfs_root,
> +                                   adap, &flash_debugfs_fops,
> +                                   adap->params.sf_size);

>    What was the point reformatting this call?

It was done to silence checkpatch.pl warnings

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html