netdev - Re: [PATCH] net: fec: fix runtime PM when probing MII bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1437401574.3071.6.camel@pengutronix.de>
Date:	Mon, 20 Jul 2015 16:12:54 +0200
From:	Lucas Stach <l.stach@...gutronix.de>
To:	Andrew Lunn <andrew@...n.ch>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Duan Andy <fugang.duan@...escale.com>,
	Frank Li <Frank.Li@...escale.com>, netdev@...r.kernel.org,
	kernel@...gutronix.de, patchwork-lst@...gutronix.de
Subject: Re: [PATCH] net: fec: fix runtime PM when probing MII bus

Am Montag, den 20.07.2015, 15:59 +0200 schrieb Andrew Lunn:
> On Mon, Jul 20, 2015 at 03:48:14PM +0200, Lucas Stach wrote:
> > In the case where there is no "mdio" bus specified in the devicetree a plain
> > mdiobus_register() will be called, which tries to probe the connected PHY
> > by doing mdio_read() on the bus.
> > Since 6c3e921b18ed (net: fec: Ensure clocks are enabled while using mdio bus)
> > this needs runtime PM to be available, but as RPM is only later set up in the
> > FEC probe function those calls will fail, which in turn prevents the FEC
> > driver to be registered successfully.
> > 
> > Fix this by moving the RPM setup calls before the MII bus probing.
> > 
> > Also move autosuspend init calls before runtime_pm_enable() so that the RPM
> > callbacks aren't invoked several times during the probe function.
> > 
> > Signed-off-by: Lucas Stach <l.stach@...gutronix.de>
> > ---
> > The offending commit got in with v4.2-rc3, so this should be applied as
> > a fix for 4.2.
> 
> Hi Lucas
> 
> The patch adding runtime PM has been reverted by David.
> 
> Are you O.K. if i fold you fix into my patch and resubmit. I will add
> your Signed-off-by.
> 
Oh, I had missed that. Thanks for the hint.

I'm ok with folding this patch into yours. Please mention that this
fixes the regression seen on i.MX6 witch caused the revert of the
original patch.

Regards,
Lucas

-- 
Pengutronix e.K.             | Lucas Stach                 |
Industrial Linux Solutions   | http://www.pengutronix.de/  |

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html