netdev - Re: [PATCH net-next 14/22] vxlan: Flow based tunneling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150720174105.GA21405@localhost.localdomain>
Date:	Mon, 20 Jul 2015 14:41:05 -0300
From:	Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
To:	Thomas Graf <tgraf@...g.ch>
Cc:	roopa@...ulusnetworks.com, rshearma@...cade.com,
	ebiederm@...ssion.com, hannes@...essinduktion.org,
	pshelar@...ira.com, jesse@...ira.com, davem@...emloft.net,
	daniel@...earbox.net, tom@...bertland.com, edumazet@...gle.com,
	jiri@...nulli.us, stephen@...workplumber.org, jpettit@...ira.com,
	kaber@...sh.net, simon.horman@...ronome.com,
	joestringer@...ira.com, ja@....bg, ast@...mgrid.com,
	weichunc@...mgrid.com, netdev@...r.kernel.org, dev@...nvswitch.org
Subject: Re: [PATCH net-next 14/22] vxlan: Flow based tunneling

On Mon, Jul 20, 2015 at 02:15:22PM -0300, Marcelo Ricardo Leitner wrote:
> On Fri, Jul 17, 2015 at 02:55:33PM +0200, Thomas Graf wrote:
> 
> [ snip ]
> 
> > @@ -2373,6 +2470,12 @@ static void vxlan_setup(struct net_device *dev)
> >  	netif_keep_dst(dev);                     ---> (a)
> >  	dev->priv_flags |= IFF_LIVE_ADDR_CHANGE;
> >  
> > +	/* If in flow based mode, keep the dst including encapsulation
> > +	 * instructions for vxlan_xmit().
> > +	 */
> > +	if (vxlan->flags & VXLAN_F_FLOW_BASED)
> > +		netif_keep_dst(dev);             ---> (b)
> > +
> >  	INIT_LIST_HEAD(&vxlan->next);
> >  	spin_lock_init(&vxlan->hash_lock);
> >  
> 
> Sounds like after 0287587884b1 ("net: better IFF_XMIT_DST_RELEASE
> support"), which introduced (a) above, (b) is not needed?

Oops, it was already reported by Alexei.

  Marcelo

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html