netdev - RE: drivers/net/phy/dp83867.c:167: possible bad if ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DUB128-W71C785FB2C2E811A329E859C850@phx.gbl>
Date:	Mon, 20 Jul 2015 18:00:24 +0000
From:	David Binderman <dcb314@...mail.com>
To:	Dan Murphy <dmurphy@...com>,
	Florian Fainelli <f.fainelli@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: drivers/net/phy/dp83867.c:167: possible bad if ?

Hello there,

----------------------------------------
> The proposed fix is logically correct. And it matches the code for
> phy_interface_is_rgmii with the '&&'.

As the original warning message indicates, I used compiler flag
-Wlogical-op to find this problem.

In order to detect this problem in future in your section of
the Linux kernel, it might be a wise idea to add compiler flag
-Wlogical-op to your builds.

If all goes well, this extra compiler flag should have nothing to say.

Just an idea.


Regards

David Binderman

 		 	   		  --
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html