netdev - Re: [PATCH net-next 2/2] enic: allow adaptive coalesce setting for msi/legacy intr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150720.123950.36893082016260196.davem@davemloft.net>
Date:	Mon, 20 Jul 2015 12:39:50 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	_govind@....com
Cc:	netdev@...r.kernel.org, ssujith@...co.com, benve@...co.com
Subject: Re: [PATCH net-next 2/2] enic: allow adaptive coalesce setting for
 msi/legacy intr

From: Govindarajulu Varadarajan <_govind@....com>
Date: Wed, 15 Jul 2015 15:34:40 +0530

> * Allow setting of adaptive coalescing setting for all types of interrupt.
> 
> * In msi & legacy intr, we use single interrupt for rx & tx. In this case
>   tx_coalesce_usecs is invalid. We should use only rx_coalesce_usecs.
>   Do not display tx_coal values for msi/intx. And do not allow user to set
>   this as well.
> 
> * Driver supports only tx/rx_coalesce_usec and adaptive coalesce settings.
>   For other values, driver does not return error. So ethtool succeeds for
>   unsupported values. Introduce enic_coalesce_valid() function to validate
>   the coalescing values.
> 
> * If user requests for coalesce value greater than what adaptor supports,
>   driver uses the max value. We should at least log this.
> 
> Signed-off-by: Govindarajulu Varadarajan <_govind@....com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html