netdev - Re: [PATCH iproute2] ss: fix display of raw sockets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150720145839.79557d38@urahara>
Date:	Mon, 20 Jul 2015 14:58:39 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Cc:	netdev@...r.kernel.org, eric.dumazet@...il.com,
	miham@...ondsemi.com, vadim4j@...il.com, davem@...emloft.net
Subject: Re: [PATCH iproute2] ss: fix display of raw sockets

On Wed, 15 Jul 2015 05:50:42 -0700
Nikolay Aleksandrov <nikolay@...ulusnetworks.com> wrote:

> After commit 8250bc9ff4e5 ("ss: Unify inet sockets output") raw sockets
> are displayed as udp because dgram_show_line() is used for both and
> thus IPPROTO_UDP is used for both so proto_name() returns "udp".
> Fix this by checking dg_proto which is set according to the caller of
> dgram_show_line().
> 
> Reported-by: Miha Marolt <miham@...ondsemi.com>
> Signed-off-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
> ---
> note: use 0 instead of IPPROTO_RAW like Eric suggested
> 
>  misc/ss.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html