netdev - Re: [PATCH net-next] bridge: mdb: add vlan support for user entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150720152817.4c2f5c73@urahara>
Date:	Mon, 20 Jul 2015 15:28:17 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Cc:	netdev@...r.kernel.org, bridge@...ts.linux-foundation.org,
	davem@...emloft.net
Subject: Re: [PATCH net-next] bridge: mdb: add vlan support for user entries

On Fri, 10 Jul 2015 08:02:08 -0700
Nikolay Aleksandrov <nikolay@...ulusnetworks.com> wrote:

> diff --git a/include/uapi/linux/if_bridge.h b/include/uapi/linux/if_bridge.h
> index eaaea6208b42..3635b7797508 100644
> --- a/include/uapi/linux/if_bridge.h
> +++ b/include/uapi/linux/if_bridge.h
> @@ -182,6 +182,7 @@ struct br_mdb_entry {
>  #define MDB_TEMPORARY 0
>  #define MDB_PERMANENT 1
>  	__u8 state;
> +	__u16 vid;
>  	struct {
>  		union {
>  			__be32	ip4;

You added a new field into an unused hole in a data
structure shared as part of API with user space.

This seems like it might break when newer iproute
is run on older kernels. The vid would always be 0
on show and ignored when adding entries.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html