netdev - Re: [PATCH] inet: frags: fix defragmented packet's IP header for af

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150720.203119.344614621480451223.davem@davemloft.net>
Date:	Mon, 20 Jul 2015 20:31:19 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	edjee@...gle.com
Cc:	willemb@...gle.com, edumazet@...gle.com, hkchu@...gle.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] inet: frags: fix defragmented packet's IP header for
 af_packet

From: Edward Jee <edjee@...gle.com>
Date: Thu, 16 Jul 2015 01:54:41 -0700

> When ip_frag_queue() computes positions, it assumes that the passed
> sk_buff does not contain L2 headers. However, when
> PACKET_FANOUT_FLAG_DEFRAG is used, IP defragmentation functions can be
> called on outgoing packets that contain L2 headers. Also, IPv4
> checksum is not corrected after defragmentation.
> 
> Fixes: 7736d33f4262 ("packet: Add pre-defragmentation support for ipv4 fanouts.")
> Signed-off-by: Edward Hyunkoo Jee <edjee@...gle.com>
> Acked-by: Eric Dumazet <edumazet@...gle.com>

This doesn't compile.

net/ipv4/ip_fragment.c: In function ‘ip_frag_reasm’:
net/ipv4/ip_fragment.c:644:23: error: ‘skb’ undeclared (first use in this function)
  ip_send_check(ip_hdr(skb));
                       ^
net/ipv4/ip_fragment.c:644:23: note: each undeclared identifier is reported only once for each function it appears in
scripts/Makefile.build:258: recipe for target 'net/ipv4/ip_fragment.o' failed
make[1]: *** [net/ipv4/ip_fragment.o] Error 1
Makefile:1527: recipe for target 'net/ipv4/ip_fragment.o' failed
make: *** [net/ipv4/ip_fragment.o] Error 2