netdev - Re: [PATCH] net: phy: dp83867: Fix warning check for setting the internal delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 21 Jul 2015 10:14:12 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Dan Murphy <dmurphy@...com>, netdev@...r.kernel.org
CC:	dcb314@...mail.com
Subject: Re: [PATCH] net: phy: dp83867: Fix warning check for setting the
 internal delay

On 21/07/15 10:06, Dan Murphy wrote:
> Fix warning: logical ‘or’ of collectively exhaustive tests is always true
> 
> Change the internal delay check from an 'or' condition to an 'and'
> condition.
> 
> Reported-by: David Binderman <dcb314@...mail.com>
> Signed-off-by: Dan Murphy <dmurphy@...com>

Acked-by: Florian Fainelli <f.fainelli@...il.com>

> ---
>  drivers/net/phy/dp83867.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
> index c7a12e2..8a3bf54 100644
> --- a/drivers/net/phy/dp83867.c
> +++ b/drivers/net/phy/dp83867.c
> @@ -164,7 +164,7 @@ static int dp83867_config_init(struct phy_device *phydev)
>  			return ret;
>  	}
>  
> -	if ((phydev->interface >= PHY_INTERFACE_MODE_RGMII_ID) ||
> +	if ((phydev->interface >= PHY_INTERFACE_MODE_RGMII_ID) &&
>  	    (phydev->interface <= PHY_INTERFACE_MODE_RGMII_RXID)) {
>  		val = phy_read_mmd_indirect(phydev, DP83867_RGMIICTL,
>  					    DP83867_DEVADDR, phydev->addr);
> 


-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html