netdev - [net-next:master 195/208] net/core/fib_rules.c:418:3: error: implicit declaration of function 'ip_tunnel_need

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <201507220721.xnKwG31c%fengguang.wu@intel.com>
Date:	Wed, 22 Jul 2015 07:38:22 +0800
From:	kbuild test robot <fengguang.wu@...el.com>
To:	Thomas Graf <tgraf@...g.ch>
Cc:	kbuild-all@...org, netdev@...r.kernel.org
Subject: [net-next:master 195/208] net/core/fib_rules.c:418:3: error:
 implicit declaration of function 'ip_tunnel_need_metadata'

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head:   16040894b26af9f85d9395f072c53d76a44eba21
commit: e7030878fc8448492b6e5cecd574043f63271298 [195/208] fib: Add fib rule match on tunnel id
config: i386-randconfig-r0-201529 (attached as .config)
reproduce:
  git checkout e7030878fc8448492b6e5cecd574043f63271298
  # save the attached .config to linux build tree
  make ARCH=i386 

All error/warnings (new ones prefixed by >>):

   net/core/fib_rules.c: In function 'fib_nl_newrule':
>> net/core/fib_rules.c:418:3: error: implicit declaration of function 'ip_tunnel_need_metadata' [-Werror=implicit-function-declaration]
      ip_tunnel_need_metadata();
      ^
   net/core/fib_rules.c: In function 'fib_nl_delrule':
>> net/core/fib_rules.c:505:4: error: implicit declaration of function 'ip_tunnel_unneed_metadata' [-Werror=implicit-function-declaration]
       ip_tunnel_unneed_metadata();
       ^
   cc1: some warnings being treated as errors

vim +/ip_tunnel_need_metadata +418 net/core/fib_rules.c

   412			ops->nr_goto_rules++;
   413	
   414		if (unresolved)
   415			ops->unresolved_rules++;
   416	
   417		if (rule->tun_id)
 > 418			ip_tunnel_need_metadata();
   419	
   420		notify_rule_change(RTM_NEWRULE, rule, ops, nlh, NETLINK_CB(skb).portid);
   421		flush_route_cache(ops);
   422		rules_ops_put(ops);
   423		return 0;
   424	
   425	errout_free:
   426		kfree(rule);
   427	errout:
   428		rules_ops_put(ops);
   429		return err;
   430	}
   431	
   432	static int fib_nl_delrule(struct sk_buff *skb, struct nlmsghdr* nlh)
   433	{
   434		struct net *net = sock_net(skb->sk);
   435		struct fib_rule_hdr *frh = nlmsg_data(nlh);
   436		struct fib_rules_ops *ops = NULL;
   437		struct fib_rule *rule, *tmp;
   438		struct nlattr *tb[FRA_MAX+1];
   439		int err = -EINVAL;
   440	
   441		if (nlh->nlmsg_len < nlmsg_msg_size(sizeof(*frh)))
   442			goto errout;
   443	
   444		ops = lookup_rules_ops(net, frh->family);
   445		if (ops == NULL) {
   446			err = -EAFNOSUPPORT;
   447			goto errout;
   448		}
   449	
   450		err = nlmsg_parse(nlh, sizeof(*frh), tb, FRA_MAX, ops->policy);
   451		if (err < 0)
   452			goto errout;
   453	
   454		err = validate_rulemsg(frh, tb, ops);
   455		if (err < 0)
   456			goto errout;
   457	
   458		list_for_each_entry(rule, &ops->rules_list, list) {
   459			if (frh->action && (frh->action != rule->action))
   460				continue;
   461	
   462			if (frh_get_table(frh, tb) &&
   463			    (frh_get_table(frh, tb) != rule->table))
   464				continue;
   465	
   466			if (tb[FRA_PRIORITY] &&
   467			    (rule->pref != nla_get_u32(tb[FRA_PRIORITY])))
   468				continue;
   469	
   470			if (tb[FRA_IIFNAME] &&
   471			    nla_strcmp(tb[FRA_IIFNAME], rule->iifname))
   472				continue;
   473	
   474			if (tb[FRA_OIFNAME] &&
   475			    nla_strcmp(tb[FRA_OIFNAME], rule->oifname))
   476				continue;
   477	
   478			if (tb[FRA_FWMARK] &&
   479			    (rule->mark != nla_get_u32(tb[FRA_FWMARK])))
   480				continue;
   481	
   482			if (tb[FRA_FWMASK] &&
   483			    (rule->mark_mask != nla_get_u32(tb[FRA_FWMASK])))
   484				continue;
   485	
   486			if (tb[FRA_TUN_ID] &&
   487			    (rule->tun_id != nla_get_be64(tb[FRA_TUN_ID])))
   488				continue;
   489	
   490			if (!ops->compare(rule, frh, tb))
   491				continue;
   492	
   493			if (rule->flags & FIB_RULE_PERMANENT) {
   494				err = -EPERM;
   495				goto errout;
   496			}
   497	
   498			if (ops->delete) {
   499				err = ops->delete(rule);
   500				if (err)
   501					goto errout;
   502			}
   503	
   504			if (rule->tun_id)
 > 505				ip_tunnel_unneed_metadata();
   506	
   507			list_del_rcu(&rule->list);
   508	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

View attachment ".config" of type "text/plain" (71733 bytes)