netdev - Re: [PATCH net-next 1/1] Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150720.204441.153673057236321524.davem@davemloft.net>
Date:	Mon, 20 Jul 2015 20:44:41 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	Woojung.Huh@...rochip.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/1] Microchip's LAN7800 family USB 2/3 to
 10/100/1000 Ethernet device driver

From: <Woojung.Huh@...rochip.com>
Date: Thu, 16 Jul 2015 22:16:05 +0000

> +static int eee_control = -1;
> +module_param(eee_control, int, 0444);
> +MODULE_PARM_DESC(eee_control, "EEPROM default(-1), disable(0) & enable(1)");

Please don't add module parameters for things configurable via ethtool and
other generic, standard, mechanisms.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html