lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20150721044534.GA22493@angus-think.lan>
Date:	Tue, 21 Jul 2015 07:45:34 +0300
From:	Vadim Kochan <vadim4j@...il.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
Cc:	Vadim Kochan <vadim4j@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2] ss: Fix crash when dump stats from /proc with
 '-p'

On Mon, Jul 20, 2015 at 01:43:40PM -0700, Stephen Hemminger wrote:
> On Mon, 20 Jul 2015 22:46:23 +0300
> Vadim Kochan <vadim4j@...il.com> wrote:
> 
> > +		if (s->name)
> > +			free(s->name);
> 
> Please don't add unnecessary conditional.
>   free(NULL) is defined to do nothing.

OK, I will re-send, this was from original version.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ