netdev - Re: [PATCH v2] net: mvneta: fix refilling for Rx DMA buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150721.003033.1524284435822402813.davem@davemloft.net>
Date:	Tue, 21 Jul 2015 00:30:33 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	simon.guinot@...uanux.org
Cc:	thomas.petazzoni@...e-electrons.com, jason@...edaemon.net,
	andrew@...n.ch, gregory.clement@...e-electrons.com,
	sebastian.hesselbarth@...il.com, netdev@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, vdonnefort@...il.com,
	yoann@...lo.fr, stable@...r.kernel.org
Subject: Re: [PATCH v2] net: mvneta: fix refilling for Rx DMA buffers

From: Simon Guinot <simon.guinot@...uanux.org>
Date: Sun, 19 Jul 2015 13:00:53 +0200

> With the actual code, if a memory allocation error happens while
> refilling a Rx descriptor, then the original Rx buffer is both passed
> to the networking stack (in a SKB) and let in the Rx ring. This leads
> to various kernel oops and crashes.
> 
> As a fix, this patch moves Rx descriptor refilling ahead of building
> SKB with the associated Rx buffer. In case of a memory allocation
> failure, data is dropped and the original DMA buffer is put back into
> the Rx ring.
> 
> Signed-off-by: Simon Guinot <simon.guinot@...uanux.org>
> Fixes: c5aff18204da ("net: mvneta: driver for Marvell Armada 370/XP network unit")
> Cc: <stable@...r.kernel.org> # v3.8+
> Tested-by: Yoann Sculo <yoann@...lo.fr>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html