netdev - Re: [PATCH net-next] ipv6: Avoid rt6_probe() taking writer lock in the fast path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 22 Jul 2015 07:19:11 +0300 (EEST)
From:	Julian Anastasov <ja@....bg>
To:	Martin KaFai Lau <kafai@...com>
cc:	netdev <netdev@...r.kernel.org>, Kernel Team <kernel-team@...com>,
	Hannes Frederic Sowa <hannes@...essinduktion.org>
Subject: Re: [PATCH net-next] ipv6: Avoid rt6_probe() taking writer lock in
 the fast path


	Hello,

On Tue, 21 Jul 2015, Martin KaFai Lau wrote:

> The patch checks neigh->nud_state before acquiring the writer lock.
> Note that rt6_probe() is only used in CONFIG_IPV6_ROUTER_PREF.

	Locking usage is absolutely correct.

> +		if (!(neigh->nud_state & NUD_VALID) &&
> +		    time_after(jiffies, neigh->updated + rt->rt6i_idev->cnf.rtr_probe_interval)) {

	but this line is too long...

> +			work = kmalloc(sizeof(*work), GFP_ATOMIC);
> +			if (work) {
> +				__neigh_set_probe_once(neigh);
> +			}

	scripts/checkpatch.pl --strict /tmp/file.patch

Regards

--
Julian Anastasov <ja@....bg>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html