netdev - Re: [PATCH iproute2] tc: fix bpf compilation with old glibc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 22 Jul 2015 09:47:02 -0700
From:	Stephen Hemminger <shemming@...cade.com>
To:	Daniel Borkmann <daniel@...earbox.net>
CC:	Nicolas Dichtel <nicolas.dichtel@...nd.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH iproute2] tc: fix bpf compilation with old glibc

On Wed, 22 Jul 2015 13:05:32 +0000
Daniel Borkmann <daniel@...earbox.net> wrote:

> On 07/22/2015 02:29 PM, Nicolas Dichtel wrote:
> > Error was:
> > f_bpf.o: In function `bpf_parse_opt':
> > f_bpf.c:(.text+0x88f): undefined reference to `secure_getenv'
> > m_bpf.o: In function `parse_bpf':
> > m_bpf.c:(.text+0x587): undefined reference to `secure_getenv'
> > collect2: error: ld returned 1 exit status
> >
> > CC: Daniel Borkmann <daniel@...earbox.net>
> > Fixes: 88eea5395483 ("tc: {f,m}_bpf: allow to retrieve uds path from env")
> > Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
> 
> Thanks Nicolas! I am thinking we should probably just stick to getenv()
> and convert these two users.
> 
> Thanks,
> Daniel

Yes, please use getenv() unless there is a obvious special
security requirement involved. 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html