netdev - Re: [PATCH net-next] af_mpls: fix undefined reference to ip6_route

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150722.104926.1502608671575195516.davem@davemloft.net>
Date:	Wed, 22 Jul 2015 10:49:26 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	tgraf@...g.ch
Cc:	roopa@...ulusnetworks.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] af_mpls: fix undefined reference to
 ip6_route_output

From: Thomas Graf <tgraf@...g.ch>
Date: Wed, 22 Jul 2015 14:23:09 +0200

> On 07/22/15 at 12:10am, Roopa Prabhu wrote:
>> From: Roopa Prabhu <roopa@...ulusnetworks.com>
>> 
>> seen with CONFIG_IPV6 disabled. Wrap the code
>> around IS_ENABLED(CONFIG_IPV6)
>> 
>> Reported-by: kbuild test robot <fengguang.wu@...el.com>
>> Signed-off-by: Roopa Prabhu <roopa@...ulusnetworks.com>
> 
> We need the same for CONFIG_INET=n in inet_fib_lookup_dev:
> 
> /home/tgraf/dev/linux/net-next/include/net/route.h:122: undefined reference to `ip_route_output_flow'
> 
> Is it worth returning EAFNOSUPPORT instead of ENODEV in these
> cases?  Something like this:
> 
>>  }
>> +#else
>> +static struct net_device *inet6_fib_lookup_dev(struct net *net, void *addr)
>> +{
>  +	return ERR_PTR(-EAFNOSUPPORT);
>> +}
>> +#endif
> 
> And then IS_ERR() in mpls_route_add()?

Also IS_ENABLED() _DOES NOT_ work, what if MPLS is 'y' and IPV6 is 'm'?

You can't reache the modular symbol from statically built code.

What a mess.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html