netdev - Re: [PATCH] net: via/Kconfig: GENERIC_PCI_IOMAP required if PCI not selected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150722.110836.422018977846427052.davem@davemloft.net>
Date:	Wed, 22 Jul 2015 11:08:36 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	borneo.antonio@...il.com
Cc:	paul.gortmaker@...driver.com, netdev@...r.kernel.org,
	linux-next@...r.kernel.org, alchark@...il.com
Subject: Re: [PATCH] net: via/Kconfig: GENERIC_PCI_IOMAP required if PCI
 not selected

From: Antonio Borneo <borneo.antonio@...il.com>
Date: Thu, 23 Jul 2015 00:34:14 +0800

> -	depends on (PCI || OF_IRQ)
> +	depends on (PCI || (OF_IRQ && GENERIC_PCI_IOMAP))

Having GENERIC_PCI_IOMAP withut PCI makes absolutely no sense to me.

I can't see why a platform would provide GENERIC_PCI_IOMAP when it
does not have PCI enabled.

You need to explain this.

When PCI is not enabled, you should not be using any interface
pci_*() whatsoever.  Especially such a core interface as pci_iomap().

ALTERNATIVELY, NOP versions of pci_iomap() and friends should be
provided when PCI is disabled, which just return errors and
non-success statuses.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html