netdev - Re: [PATCH net-next] af_mpls: fix undefined reference to ip6_route

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55AFFB71.5040307@cumulusnetworks.com>
Date:	Wed, 22 Jul 2015 13:22:09 -0700
From:	roopa <roopa@...ulusnetworks.com>
To:	David Miller <davem@...emloft.net>
CC:	tgraf@...g.ch, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] af_mpls: fix undefined reference to ip6_route_output

On 7/22/15, 1:04 PM, David Miller wrote:
> From: Thomas Graf <tgraf@...g.ch>
> Date: Wed, 22 Jul 2015 21:57:06 +0200
>
>> On 07/22/15 at 12:30pm, roopa wrote:
>>> diff --git a/net/mpls/Kconfig b/net/mpls/Kconfig
>>> index 5c467ef..2b28615 100644
>>> --- a/net/mpls/Kconfig
>>> +++ b/net/mpls/Kconfig
>>> @@ -24,6 +24,8 @@ config NET_MPLS_GSO
>>>
>>>   config MPLS_ROUTING
>>>          tristate "MPLS: routing support"
>>> +       depends on INET
>>> +       depends on IPV6
>>>          ---help---
>>>           Add support for forwarding of mpls packets.
>> This looks like a much better fix to me and resolves the
>> module/built-in dependency mess.
> It's only OK if we don't create a new hard dependency on IPV6,
> which this patch does.
>
> Consitently across the tree we give the user the option of
> using a bi-AF facility with or without IPV6.
yes, ack. I have been trying to avoid that ...also because
af_mpls does support a family AF_PACKET mode that should continue to 
work without CONFIG_INET and CONFIG_INET6
(Though I have not tried it).




--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html