netdev - Re: [PATCH net] netlink: don't hold mutex in rcu callback when releasing mmapd ring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150721.222322.1270246148178121431.davem@davemloft.net>
Date:	Tue, 21 Jul 2015 22:23:22 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	fw@...len.de
Cc:	netdev@...r.kernel.org, kirill@...temov.name,
	cwang@...pensource.com, tgraf@...g.ch, kaber@...sh.net
Subject: Re: [PATCH net] netlink: don't hold mutex in rcu callback when
 releasing mmapd ring

From: Florian Westphal <fw@...len.de>
Date: Tue, 21 Jul 2015 16:33:50 +0200

> Kirill A. Shutemov says:
> 
> This simple test-case trigers few locking asserts in kernel:
 ...
> Cong Wang says:
> 
> We can't hold mutex lock in a rcu callback, [..]
> 
> Thomas Graf says:
> 
> The socket should be dead at this point. It might be simpler to
> add a netlink_release_ring() function which doesn't require
> locking at all.
> 
> Reported-by: "Kirill A. Shutemov" <kirill@...temov.name>
> Diagnosed-by: Cong Wang <cwang@...pensource.com>
> Suggested-by: Thomas Graf <tgraf@...g.ch>
> Signed-off-by: Florian Westphal <fw@...len.de>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html