netdev - Re: [PATCH] cgroup: net_cls: fix false-positive "suspicious RCU usage"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150721.222858.1855944921733592230.davem@davemloft.net>
Date:	Tue, 21 Jul 2015 22:28:58 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	khlebnikov@...dex-team.ru
Cc:	netdev@...r.kernel.org, tj@...nel.org, cgroups@...r.kernel.org,
	lizefan@...wei.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cgroup: net_cls: fix false-positive "suspicious RCU
 usage"

From: Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
Date: Tue, 21 Jul 2015 19:46:29 +0300

> @@ -23,7 +23,8 @@ static inline struct cgroup_cls_state *css_cls_state(struct cgroup_subsys_state
>  
>  struct cgroup_cls_state *task_cls_state(struct task_struct *p)
>  {
> -	return css_cls_state(task_css(p, net_cls_cgrp_id));
> +       return css_cls_state(task_css_check(p, net_cls_cgrp_id,
> +			       rcu_read_lock_bh_held()));

You've made a serious mess of the indentation here.

First of all, you've changed the correct plain "TAB" before the 'return' line
into a TAB and two SPACE characters.

Secondly, the second line needs to be precisely indented to the exact column
following the openning parenthesis of the task_css_check() call on the
previous line.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html