netdev - Re: [PATCH,v2 net] net: sched: validate that class is found in qdisc_tree_decrease

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpXwxyB0NKqkmxSUTDyi+mGk6T1i-JQ6XEk8z=_jq7K20w@mail.gmail.com>
Date:	Tue, 21 Jul 2015 19:03:58 -0700
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Jamal Hadi Salim <jhs@...atatu.com>,
	Alex Gartrell <agartrell@...com>,
	David Miller <davem@...emloft.net>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	kernel-team@...com, stable@...r.kernel.org
Subject: Re: [PATCH,v2 net] net: sched: validate that class is found in qdisc_tree_decrease_qlen

On Tue, Jul 21, 2015 at 1:57 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> On Tue, 2015-07-21 at 11:12 -0700, Cong Wang wrote:
>
>> > -               kfree_skb(skb);
>> > +       INIT_LIST_HEAD(&q->new_flows);
>> > +       INIT_LIST_HEAD(&q->old_flows);
>> > +       for (i = 0; i < q->flows_cnt; i++) {
>> > +               struct fq_codel_flow *flow = q->flows + i;
>> > +
>> > +               while (flow->head)
>> > +                       kfree_skb(dequeue_head(flow));
>> > +
>> > +               INIT_LIST_HEAD(&flow->flowchain);
>>
>>
>> You probably need to call codel_vars_init(&flow->cvars) as well.
>
> It is not necessary : flow->cvars only matter in the event of a dequeue,
> but whole qdisc is dismantled and no packet will be dequeued.
>

But it will affect the next dequeue _after_ reset? which is not supposed
to happen as we expect a fresh start after reset?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html