netdev - Re: [PATCH net] bridge: stp: when using userspace stp stop kernel hello and hold timers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150723095945.2b4dd59e@urahara>
Date:	Thu, 23 Jul 2015 09:59:45 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Cc:	netdev@...r.kernel.org, bridge@...ts.linux-foundation.org,
	davem@...emloft.net, Satish Ashok <sashok@...ulusnetworks.com>
Subject: Re: [PATCH net] bridge: stp: when using userspace stp stop kernel
 hello and hold timers

On Thu, 23 Jul 2015 09:07:37 -0700
Nikolay Aleksandrov <nikolay@...ulusnetworks.com> wrote:

> +		/* Stop hello and hold timer */
> +		spin_lock_bh(&br->lock);
> +		del_timer(&br->hello_timer);
> +		list_for_each_entry(p, &br->port_list, list)
> +			del_timer(&p->hold_timer);
> +		spin_unlock_bh(&br->lock);

Wouldn't it be easier to use del_timer_sync here?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html