lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 23 Jul 2015 11:30:30 +0000
From:	Hayes Wang <hayeswang@...ltek.com>
To:	Oliver Neukum <oneukum@...e.com>
CC:	nic_swsd <nic_swsd@...ltek.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net 2/3] r8152: fix remote wakeup

Oliver Neukum [mailto:oneukum@...e.com]
[...]
> If the device does not support remote wakeup and the driver enables it, runtime
> power management will be switched off.
> That is the current state and it means that devices which don't support remote
> wakeup cannot do runtime power management at all. But the driver is correct.
> 
> The only time a device that doesn't support remote wakeup can do runtime power
> managent is when no packets can be received that is while the interface is down. If
> you want to allow that you must not set needs_remote_wakeup in probe(), but you
> must set it in open() because it is necessary for runtime power management as I
> explained above.
> 
> Sorry for the length of this mail, but I wanted to make sure I am absolutely clear
> this time.

Thanks for you explanation. I focus on the wrong point. You mean this would cause
the problem for runtime suspend. I would rethink my method and correct it.

Best Regards,
Hayes

Powered by blists - more mailing lists