netdev - RE: [v3, 5/9] fsl/fman: Add Frame Manager support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM2PR03MB383CBFE012027E474F683E3E6820@DM2PR03MB383.namprd03.prod.outlook.com>
Date:	Thu, 23 Jul 2015 12:45:50 +0000
From:	Liberman Igal <Igal.Liberman@...escale.com>
To:	Liberman Igal <Igal.Liberman@...escale.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:	"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Scott Wood <scottwood@...escale.com>,
	Madalin-Cristian Bucur <madalin.bucur@...escale.com>,
	"pebolle@...cali.nl" <pebolle@...cali.nl>,
	"joakim.tjernlund@...nsmode.se" <joakim.tjernlund@...nsmode.se>,
	"ppc@...dchasers.com" <ppc@...dchasers.com>
Subject: RE: [v3, 5/9] fsl/fman: Add Frame Manager support


Regards,
Igal Liberman.

> +static struct platform_driver fm_driver = {
> +	.driver = {
> +		   .name = "fsl-fman",
> +		   .of_match_table = fm_match,
> +		   },
> +	.probe = fm_probe,
> +};
> +
> +builtin_platform_driver(fm_driver);
> +
> +static int __init __cold fm_load(void)
> +{
> +	if (platform_driver_register(&fm_driver)) {
> +		pr_crit("platform_driver_register() failed\n");
> +		return -ENODEV;
> +	}
> +
> +	pr_info("Freescale FMan module\n");
> +	return 0;
> +}
> +
> +device_initcall(fm_load);

Please notice, when using builtin_platform_driver, device_initcall(fm_load); becomes redundant. 
Same issue in 2 other places.
I have patches which fix that which were left out of this submission, I'll add them to v4.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html