[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <55B0E6B9.3070301@cogentembedded.com>
Date: Thu, 23 Jul 2015 16:06:01 +0300
From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To: Taku Izumi <izumi.taku@...fujitsu.com>, netdev@...r.kernel.org,
davem@...emloft.net
Cc: platform-driver-x86@...r.kernel.org, dvhart@...radead.org,
rkhan@...hat.com, alexander.h.duyck@...hat.com,
linux-acpi@...r.kernel.org, joe@...ches.com,
stephen@...workplumber.org, yasu.isimatu@...il.com
Subject: Re: [PATCH v2.1 21/22] fjes: handle receive cancellation request
interrupt
Hello.
On 7/23/2015 3:10 AM, Taku Izumi wrote:
> This patch adds implementation of handling IRQ
> of other receiver's receive cancellation request.
> Signed-off-by: Taku Izumi <izumi.taku@...fujitsu.com>
> ---
> drivers/net/fjes/fjes_main.c | 79 ++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 79 insertions(+)
>
> diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c
> index faaf2ed..b21ad68 100644
> --- a/drivers/net/fjes/fjes_main.c
> +++ b/drivers/net/fjes/fjes_main.c
> @@ -822,6 +822,75 @@ static int fjes_vlan_rx_kill_vid(struct net_device *netdev,
> return 0;
> }
>
> +static void fjes_txrx_stop_req_irq(struct fjes_adapter *adapter,
> + int src_epid)
> +{
> + struct fjes_hw *hw = &adapter->hw;
> + enum ep_partner_status status;
> +
> + status = fjes_hw_get_partner_ep_status(hw, src_epid);
> + switch (status) {
> + case EP_PARTNER_UNSHARE:
> + default:
> + break;
> + case EP_PARTNER_COMPLETE:
> + break;
Why this *case* isn't merged with the above ones?
> + case EP_PARTNER_WAITING:
> + if (src_epid < hw->my_epid) {
> + hw->ep_shm_info[src_epid].tx.info->v1i.rx_status |=
> + FJES_RX_STOP_REQ_DONE;
> +
> + clear_bit(src_epid, &hw->txrx_stop_req_bit);
> + set_bit(src_epid, &adapter->unshare_watch_bitmask);
> +
> + if (!work_pending(&adapter->unshare_watch_task))
> + queue_work(adapter->control_wq,
> + &adapter->unshare_watch_task);
> + }
> + break;
> + case EP_PARTNER_SHARED:
> + if (hw->ep_shm_info[src_epid].rx.info->v1i.rx_status
> + & FJES_RX_STOP_REQ_REQUEST) {
Please leave the & operator on the first line and start the second line
right under 'hw' on the first.
[...]
MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists