netdev - Re: [PATCH net] tcp: fix recv with flags MSG_WAITALL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1437757556.20182.9.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Fri, 24 Jul 2015 19:05:56 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Sabrina Dubroca <sd@...asysnail.net>
Cc:	netdev@...r.kernel.org, Enrico Scholz <rh-bugzilla@...c.de>,
	Dan Searle <dan@...sornet.com>
Subject: Re: [PATCH net] tcp: fix recv with flags MSG_WAITALL | MSG_PEEK

On Fri, 2015-07-24 at 18:19 +0200, Sabrina Dubroca wrote:
> Currently, tcp_recvmsg enters a busy loop in sk_wait_data if called
> with flags = MSG_WAITALL | MSG_PEEK.
> 
> sk_wait_data waits for sk_receive_queue not empty, but in this case,
> the receive queue is not empty, but does not contain any skb that we
> can use.
> 
> Add a "last skb seen on receive queue" argument to sk_wait_data, so
> that it sleeps until the receive queue has new skbs.
> 
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=99461
> Link: https://sourceware.org/bugzilla/show_bug.cgi?id=18493
> Link: https://bugzilla.redhat.com/show_bug.cgi?id=1205258
> Reported-by: Enrico Scholz <rh-bugzilla@...c.de>
> Reported-by: Dan Searle <dan@...sornet.com>
> Signed-off-by: Sabrina Dubroca <sd@...asysnail.net>
> ---

Very nice !

Acked-by: Eric Dumazet <edumazet@...gle.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html