netdev - Re: [RFC PATCH v4 net-next 1/4] tcp: replace cnt & rtt with struct in pkts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1437805332.20182.11.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Sat, 25 Jul 2015 08:22:12 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Lawrence Brakmo <brakmo@...com>
Cc:	netdev <netdev@...r.kernel.org>, Kernel Team <kernel-team@...com>,
	Neal Cardwell <ncardwell@...gle.com>,
	Yuchung Cheng <ycheng@...gle.com>
Subject: Re: [RFC PATCH v4 net-next 1/4] tcp: replace cnt & rtt with struct
 in pkts_acked()

On Fri, 2015-07-24 at 19:47 -0700, Lawrence Brakmo wrote:
> Replace 2 arguments (cnt and rtt) in the congestion control modules'
> pkts_acked() function with a struct. This will allow adding more
> information without having to modify existing congestion control
> modules (tcp_nv in particular needs bytes in flight when packet
> was sent).
> 
>  
> +struct ack_sample {
> +	u32 pkts_acked;
> +	s32 rtt_us;
> +};
> +
>  struct tcp_congestion_ops {
>  	struct list_head	list;
>  	u32 key;
> @@ -857,7 +862,7 @@ struct tcp_congestion_ops {
>  	/* new value of cwnd after loss (optional) */
>  	u32  (*undo_cwnd)(struct sock *sk);
>  	/* hook for packet ack accounting (optional) */
> -	void (*pkts_acked)(struct sock *sk, u32 num_acked, s32 rtt_us);
> +	void (*pkts_acked)(struct sock *sk, struct ack_sample *sample);

This probably should be a const struct ack_sample *sample ?



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html