netdev - Re: [PATCH net-next] r8169: correct size from ... (snip)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150726225801.GA14837@electric-eye.fr.zoreil.com>
Date:	Mon, 27 Jul 2015 00:58:01 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Corcodel Marian <corcodel.marian@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] r8169: correct size from ... (snip)

Corcodel Marian <corcodel.marian@...il.com> :
[...]
> @@ -7594,7 +7595,7 @@ static int rtl_open(struct net_device *dev)
>  	if (!tp->TxDescArray)
>  		goto err_pm_runtime_put;
>  
> -	tp->RxDescArray = dma_alloc_coherent(&pdev->dev, R8169_RX_RING_BYTES,
> +	tp->RxDescArray = dma_alloc_coherent(&pdev->dev, rx_buf_sz,
>  					     &tp->RxPhyAddr, GFP_KERNEL);

1. RxDescArray is the descriptor ring. It does not care about rx_buf_sz.

2. I don't see how R8169_RX_RING_BYTES could reach 17000:

#define NUM_RX_DESC     256U    /* Number of Rx descriptor registers */
[...]
#define R8169_RX_RING_BYTES     (NUM_RX_DESC * sizeof(struct RxDesc))
[...]
struct RxDesc {
        __le32 opts1;
        __le32 opts2;   
        __le64 addr;
};

256 * 16 = 4096

3. The Subject: field should not include the verbose change description.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html