netdev - Re: [PATCH net] bridge: netlink: fix slave_changelink/br

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150726.162827.595252911514712549.davem@davemloft.net>
Date:	Sun, 26 Jul 2015 16:28:27 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	razor@...ckwall.org
Cc:	netdev@...r.kernel.org, jiri@...nulli.us,
	bridge@...ts.linux-foundation.org, stephen@...workplumber.org,
	nikolay@...ulusnetworks.com
Subject: Re: [PATCH net] bridge: netlink: fix slave_changelink/br_setport
 race conditions

From: Nikolay Aleksandrov <razor@...ckwall.org>
Date: Wed, 22 Jul 2015 13:03:40 +0200

> From: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
> 
> Since slave_changelink support was added there have been a few race
> conditions when using br_setport() since some of the port functions it
> uses require the bridge lock. It is very easy to trigger a lockup due to
> some internal spin_lock() usage without bh disabled, also it's possible to
> get the bridge into an inconsistent state.
> 
> Signed-off-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
> Fixes: 3ac636b8591c ("bridge: implement rtnl_link_ops->slave_changelink")

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html