[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20150726.163520.846046458508685868.davem@davemloft.net>
Date: Sun, 26 Jul 2015 16:35:20 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: madalin.bucur@...escale.com
Cc: joe@...ches.com, netdev@...r.kernel.org,
linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
scottwood@...escale.com, Igal.Liberman@...escale.com,
ppc@...dchasers.com, pebolle@...cali.nl,
joakim.tjernlund@...nsmode.se
Subject: Re: [PATCH 03/10] dpaa_eth: add configurable bpool thresholds
From: Madalin-Cristian Bucur <madalin.bucur@...escale.com>
Date: Fri, 24 Jul 2015 15:49:39 +0000
>> -----Original Message-----
>> From: Joe Perches [mailto:joe@...ches.com]
>> On Wed, 2015-07-22 at 19:16 +0300, Madalin Bucur wrote:
>> > Allow the user to tweak the refill threshold and the total number
>> > of buffers in the buffer pool. The provided values are for one CPU.
>>
>> Any value in making these module parameters instead?
>
> I expect one would (hardly ever) change these to improve some corner
> cases then use them with the new values. It may help in the tuning process
> but afterwards the bloat to the bootcmd would probably be a nuisance.
I think these should be controlled by the existing ethtool infrastructure.
Neither the Kconfig mechanism nor module parameters are appropriate, at all.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists