netdev - Re: [PATCH net-next] af_mpls: fix undefined reference to ip6_route

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150726.172041.1776472283136301057.davem@davemloft.net>
Date:	Sun, 26 Jul 2015 17:20:41 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	roopa@...ulusnetworks.com
Cc:	tgraf@...g.ch, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] af_mpls: fix undefined reference to
 ip6_route_output

From: roopa <roopa@...ulusnetworks.com>
Date: Thu, 23 Jul 2015 06:44:13 -0700

> On 7/23/15, 12:09 AM, David Miller wrote:
>> From: roopa <roopa@...ulusnetworks.com>
>> Date: Wed, 22 Jul 2015 13:38:31 -0700
>>
>>> I cant think of a way to fix the current problem with my patch...
>> I guess it's not obvious that adding CONFIG_MPLS_IPV6 would solve
>> the problem perfectly.
> I thought that was not an option because CONFIG_MPLS_ROUTING is
> already out and supports IPV6 when RTA_OIF is
> specified.
> 
> I did submit another version yesterday using IS_BUILTIN (sorry missed
> the v2 in the patch prefix).
> https://patchwork.ozlabs.org/patch/498903/
> 
> I can certainly introduce CONFIG_MPLS_IPV6, if that is a more
> acceptable.

Also, IS_BUILTIN() is the wrong check, because this works properly also
when both MPLS_ROUTING and IPV6 are modular.

You need to encode this in the Kconfig dependencies of a new option
(which uses the dependency expression "IPV6 || IPV6=n"), then you can
key off of that Kconfig symbol to determine whether you need to
provide those NOP fallbacks or not.  There really is no other option.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html